Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1116198012
##########
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java:
##########
@@ -151,11 +154,12 @@ public Builder addPartition(
public <P> Builder addPartitions(
String topicName,
+ Uuid topicId,
List<P> partitions,
Function<P, Integer> partitionIndex,
Errors error
) {
- final OffsetCommitResponseTopic topicResponse =
getOrCreateTopic(topicName);
+ final OffsetCommitResponseTopic topicResponse =
getOrCreateTopic(topicName, topicId);
Review Comment:
You are right, thanks for finding this bug (again!). I followed the approach
you suggest here in the builder of the `OffsetCommitResponse`, please let me
know if the semantics make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
