guozhangwang commented on code in PR #13318:
URL: https://github.com/apache/kafka/pull/13318#discussion_r1151222236
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -312,16 +305,20 @@ private void
addToExceptionsAndFailedTasksThenClearUpdatingTasks(final Exception
updatingTasks.clear();
}
- private void waitIfAllChangelogsCompletelyRead() throws
InterruptedException {
- if (isRunning.get() && changelogReader.allChangelogsCompleted()) {
- tasksAndActionsLock.lock();
- try {
- while (tasksAndActions.isEmpty() &&
!isTopologyResumed.get()) {
- tasksAndActionsCondition.await();
- }
- } finally {
- tasksAndActionsLock.unlock();
+ private void waitIfAllChangelogsCompletelyRead() {
+ tasksAndActionsLock.lock();
Review Comment:
The name comes from the `TaskAndAction` class, which I think is still
appropriate even if we are left with `add` and `remove` actions. What's your
suggestion for a better naming?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
