[GitHub] [kafka] cadonna commented on a diff in pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

[via GitHub]

cadonna commented on code in PR #13318:
URL: https://github.com/apache/kafka/pull/13318#discussion_r1153198801


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -140,16 +134,15 @@ public void run() {
             log.info("State updater thread started");
             try {
                 while (isRunning.get()) {
-                    try {
-                        runOnce();
-                    } catch (final InterruptedException | InterruptException 
interruptedException) {
-                        return;
-                    }
+                    // in state updater we never interrupt the thread
+                    // or wakeup the consumer, hence any of
+                    // InterruptException / WakeupException
+                    // should never happen
+                    runOnce();

Review Comment:
   I still would like to get rid of this comment since `runOnce()` does not 
throw a `InterruptedException anymore`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org