[GitHub] [kafka] cadonna commented on a diff in pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

[via GitHub]

cadonna commented on code in PR #13318:
URL: https://github.com/apache/kafka/pull/13318#discussion_r1153194298


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -312,16 +305,20 @@ private void 
addToExceptionsAndFailedTasksThenClearUpdatingTasks(final Exception
             updatingTasks.clear();
         }
 
-        private void waitIfAllChangelogsCompletelyRead() throws 
InterruptedException {
-            if (isRunning.get() && changelogReader.allChangelogsCompleted()) {
-                tasksAndActionsLock.lock();
-                try {
-                    while (tasksAndActions.isEmpty() && 
!isTopologyResumed.get()) {
-                        tasksAndActionsCondition.await();
-                    }
-                } finally {
-                    tasksAndActionsLock.unlock();
+        private void waitIfAllChangelogsCompletelyRead() {
+            tasksAndActionsLock.lock();

Review Comment:
   I re-read the code and could not came up with a better name. Let's keep it 
as it is for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org