[GitHub] [kafka] erikvanoosten commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

[via GitHub]

erikvanoosten commented on code in PR #13678:
URL: https://github.com/apache/kafka/pull/13678#discussion_r1197512217


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##########
@@ -1075,6 +1078,7 @@ void invokeCompletedOffsetCommitCallbacks() {
     public RequestFuture<Void> commitOffsetsAsync(final Map<TopicPartition, 
OffsetAndMetadata> offsets, final OffsetCommitCallback callback) {
         invokeCompletedOffsetCommitCallbacks();
 
+        inFlightAsyncCommits.incrementAndGet();

Review Comment:
   @philipnee I rebased the branch on trunk so the line numbers changed a bit. 
Instead of line 1142, Is it now line 1118 (in the onFailure block inside 
`commitOffsetsAsync`)?
   
   I made changes based on your idea. I think we should keep the increment in 
`doCommitOffsetsAsync` because that is also where the decrement is. 
`inFlightAsyncCommits` is now only updated in that method. WDYT?
   
   Also, instead of using a try/finally, I moved the decrement to the top of 
the callback method.
   
   This is committed in 
https://github.com/apache/kafka/pull/13678/commits/f8ce359de5e0a7921bfac26da39feb2af11a9f09.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org