philipnee commented on code in PR #13678:
URL: https://github.com/apache/kafka/pull/13678#discussion_r1197985175
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##########
@@ -600,6 +602,30 @@ public void testCoordinatorNotAvailable() {
assertTrue(coordinator.coordinatorUnknown());
}
+ @Test
+ public void testSyncCommitWithoutOffsetsAndPendingAsyncCommit() {
+ client.prepareResponse(groupCoordinatorResponse(node, Errors.NONE));
+ coordinator.ensureCoordinatorReady(time.timer(Long.MAX_VALUE));
+
+ TopicPartition tp = new TopicPartition("foo", 0);
+ Map<TopicPartition, OffsetAndMetadata> offsets = singletonMap(tp, new
OffsetAndMetadata(123));
+
+ final AtomicBoolean committed = new AtomicBoolean();
Review Comment:
does this need to be atomic? there shouldn't be concurrent access to the
var.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
