erikvanoosten commented on code in PR #13678:
URL: https://github.com/apache/kafka/pull/13678#discussion_r1200842817
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##########
@@ -600,6 +601,30 @@ public void testCoordinatorNotAvailable() {
assertTrue(coordinator.coordinatorUnknown());
}
+ @Test
+ public void testSyncCommitWithoutOffsetsAndPendingAsyncCommit() {
Review Comment:
Sorry, somehow I missed this comment. Yes, I agree your suggestion is much
better. Applied in
https://github.com/apache/kafka/pull/13678/commits/13bccc7afe6422f48f87bda031083dde50802649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
