cmccabe commented on code in PR #13758:
URL: https://github.com/apache/kafka/pull/13758#discussion_r1210810667
##########
core/src/main/scala/kafka/zk/ZkMigrationClient.scala:
##########
@@ -303,6 +304,14 @@ class ZkMigrationClient(
new
util.HashSet[Integer](zkClient.getSortedBrokerList.map(Integer.valueOf).toSet.asJava)
}
+ override def readProducerId(): util.Optional[java.lang.Long] = {
Review Comment:
This doesn't seem to be returning nextProducerId, it's returning the current
producer id.
Why not just have `writeProducerId` take a `ProducerIdsBlock` object so we
don't have to do a bunch of dubious translation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
