cmccabe commented on code in PR #13758:
URL: https://github.com/apache/kafka/pull/13758#discussion_r1210814541
##########
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##########
@@ -566,15 +578,46 @@ public void run() throws Exception {
ZkMigrationLeadershipState newState =
migrationLeadershipState.withKRaftMetadataOffsetAndEpoch(
offsetAndEpochAfterMigration.offset(),
offsetAndEpochAfterMigration.epoch());
- applyMigrationOperation("Finished migrating ZK data", state ->
zkMigrationClient.setMigrationRecoveryState(newState));
-
transitionTo(MigrationDriverState.KRAFT_CONTROLLER_TO_BROKER_COMM);
+ applyMigrationOperation("Finished migrating ZK data to KRaft",
state -> zkMigrationClient.setMigrationRecoveryState(newState));
Review Comment:
Maybe add a comment here about how we always go through the sync kraft -> zk
state here, even immediately after we've loaded from zk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
