cmccabe commented on code in PR #13758:
URL: https://github.com/apache/kafka/pull/13758#discussion_r1210813001
##########
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##########
@@ -149,10 +152,9 @@ CompletableFuture<MigrationDriverState> migrationState() {
}
private void recoverMigrationStateFromZK() {
- log.info("Recovering migration state from ZK");
- applyMigrationOperation("Recovery",
zkMigrationClient::getOrCreateMigrationRecoveryState);
+ applyMigrationOperation("Recovering migration state from ZK",
zkMigrationClient::getOrCreateMigrationRecoveryState);
String maybeDone = migrationLeadershipState.zkMigrationComplete() ?
"done" : "not done";
- log.info("Recovered migration state {}. ZK migration is {}.",
migrationLeadershipState, maybeDone);
+ log.info("ZK migration is {}.", maybeDone);
Review Comment:
I'd really prefer to say something like "Initial ZK load is done" / "Initial
ZK load is not done"
We should also change `ZkMigrationLeadershipState.zkMigrationComplete` ->
`ZkMigrationLeadershipState.initialZkLoadComplete`
After all, the whole process here is technically "ZK migration" not just the
initial load
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
