gaurav-narula commented on code in PR #13949:
URL: https://github.com/apache/kafka/pull/13949#discussion_r1252255468


##########
core/src/main/scala/kafka/server/DelayedProduce.scala:
##########
@@ -58,6 +62,8 @@ class DelayedProduce(delayMs: Long,
                      lockOpt: Option[Lock] = None)
   extends DelayedOperation(delayMs, lockOpt) {
 
+  override lazy val logger = DelayedProduce.logger

Review Comment:
   That fails compilation with the following error:
   
   ```
   stable, immutable value required to override:
   lazy protected val logger: com.typesafe.scalalogging.Logger (defined in 
trait Logging)
   ```
   
   I suppose we cannot override a `lazy val` with a `def`.
   
   Example: https://scastie.scala-lang.org/qI1plzLAQsC10hYbEBHk5A



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to