ableegoldman commented on code in PR #14139:
URL: https://github.com/apache/kafka/pull/14139#discussion_r1282604132
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java:
##########
@@ -43,26 +51,39 @@
import org.slf4j.LoggerFactory;
public class RackAwareTaskAssignor {
+
+ @FunctionalInterface
+ public interface MoveStandbyTaskPredicate {
+ boolean canMove(final ClientState source,
+ final ClientState destination,
+ final TaskId taskId,
+ final Map<UUID, ClientState> clientStateMap);
+ }
+
private static final Logger log =
LoggerFactory.getLogger(RackAwareTaskAssignor.class);
private static final int SOURCE_ID = -1;
private final Cluster fullMetadata;
private final Map<TaskId, Set<TopicPartition>> partitionsForTask;
+ private final Map<TaskId, Set<TopicPartition>> changelogPartitionsForTask;
private final AssignmentConfigs assignmentConfigs;
private final Map<TopicPartition, Set<String>> racksForPartition;
private final Map<UUID, String> racksForProcess;
private final InternalTopicManager internalTopicManager;
private final boolean validClientRack;
+ private Boolean canEnable = null;
public RackAwareTaskAssignor(final Cluster fullMetadata,
final Map<TaskId, Set<TopicPartition>>
partitionsForTask,
+ final Map<TaskId, Set<TopicPartition>>
changelogPartitionsForTask,
final Map<Subtopology, Set<TaskId>>
tasksForTopicGroup,
Review Comment:
Seems like this is still unused, just wondering is there a plan for it
eventually?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
