lihaosky commented on code in PR #14139:
URL: https://github.com/apache/kafka/pull/14139#discussion_r1284914061
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StickyTaskAssignor.java:
##########
@@ -57,6 +57,7 @@ public StickyTaskAssignor() {
public boolean assign(final Map<UUID, ClientState> clients,
final Set<TaskId> allTaskIds,
final Set<TaskId> statefulTaskIds,
+ final RackAwareTaskAssignor rackAwareTaskAssignor,
Review Comment:
Sounds good
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java:
##########
@@ -124,11 +132,20 @@ private static void assignActiveStatefulTasks(final
SortedMap<UUID, ClientState>
ClientState::assignActive,
(source, destination) -> true
);
+
+ if (rackAwareTaskAssignor != null &&
rackAwareTaskAssignor.canEnableRackAwareAssignor()) {
+ final int trafficCost = configs.rackAwareAssignmentTrafficCost ==
null ?
Review Comment:
Because the costs are different for stateful and stateless tasks. So setting
in constructor means we need to pass in two RackAwareTaskAssignor objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
