lihaosky commented on code in PR #14139:
URL: https://github.com/apache/kafka/pull/14139#discussion_r1286438784


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java:
##########
@@ -124,11 +133,20 @@ private static void assignActiveStatefulTasks(final 
SortedMap<UUID, ClientState>
             ClientState::assignActive,
             (source, destination) -> true
         );
+
+        if (rackAwareTaskAssignor != null && rackAwareTaskAssignor.isPresent() 
&& rackAwareTaskAssignor.get().canEnableRackAwareAssignor()) {

Review Comment:
   I think currently it's because there are tests not modified and still passes 
null. I can remove this in my next PR after I modified all `HAAssignor` tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to