mjsax commented on code in PR #14103:
URL: https://github.com/apache/kafka/pull/14103#discussion_r1290555860
##########
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##########
@@ -947,9 +947,15 @@ public String toString() {
}
public static class ValidString implements Validator {
- final List<String> validStrings;
+ // visible for testing
Review Comment:
This does not really help, because in the end we need a `List` of config
values -- the source of truth what config value we support is inside the
`CONFIG` object, so we need to get it from there IMHO.
If we don't want to tap into the `CONFIG` object, we can maintain a list
ourselves, but I think it defeats the purpose of the test, as we again have a
"split brain" problem for which we need to keep the `CONFIG` and our manually
maintained list in sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
