mjsax commented on code in PR #14103:
URL: https://github.com/apache/kafka/pull/14103#discussion_r1290589930
##########
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##########
@@ -947,9 +947,15 @@ public String toString() {
}
public static class ValidString implements Validator {
- final List<String> validStrings;
+ // visible for testing
Review Comment:
I pushed a corresponding update, but I am not super happy with it... I
believe the original idea to get the list of values from `CONFIG` is safer.
Curious to hear what others think. In the end I am fine both ways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
