[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

[via GitHub]

mjsax commented on code in PR #14103:
URL: https://github.com/apache/kafka/pull/14103#discussion_r1290575646


##########
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##########
@@ -947,9 +947,15 @@ public String toString() {
     }
 
     public static class ValidString implements Validator {
-        final List<String> validStrings;
+        // visible for testing

Review Comment:
   This part does not work: `public static final String UPGRADE_FROM_34 = 
UpgradeFromValues.UPGRADE_FROM_34.toString();`
   
   We use
   ```
   switch ((String) upgradeFrom) {
                   case StreamsConfig.UPGRADE_FROM_0100:
                   ...
   }
   ```
   and the compiler complain that `StreamsConfig.UPGRADE_FROM_0100` must be a 
const
   ```
   error: constant string expression required
       case StreamsConfig.UPGRADE_FROM_0100:
   ```
   
   So not sure if we gain much adding the enum? -- We would still need to 
remember update the enum, and thus have a "split brain" problem -- getting the 
List out of the `CONFIG` object seems to be safer.
   
   Thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org