cmccabe commented on PR #14213: URL: https://github.com/apache/kafka/pull/14213#issuecomment-1679620704
> The RecordsBatchReader implementation is also changed to include control records. This makes it possible for the state machine learn about committed control records. This additional information can be used to compute the committed offset or for counting those bytes when determining when to snapshot the partition. I think we should do this change separately, since it may require downstream changes. I think a few implementations assume they don't get "empty" batches (that don't have records), which would no longer be true if control record batches were sent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
