hachikuji commented on code in PR #14213:
URL: https://github.com/apache/kafka/pull/14213#discussion_r1297486408
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -2656,6 +2656,12 @@ private void maybeFireLeaderChange(LeaderAndEpoch
leaderAndEpoch, long epochStar
// as the listener has caught up to the start of the leader epoch.
This guarantees
// that the state machine has seen the full committed state before
it becomes
// leader and begins writing to the log.
+ //
+ // Note that the raft client doesn't need to compare nextOffset
against the high-watermark
+ // to gurantee that the listener has caught up to the
high-watermark. This is true because
Review Comment:
nit: guarantee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
