divijvaidya commented on code in PR #14427:
URL: https://github.com/apache/kafka/pull/14427#discussion_r1334642477
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##########
@@ -50,6 +50,7 @@ public class RemoteLogMetadataSerde {
private final Map<Short, RemoteLogMetadataTransform> keyToTransform;
private final BytesApiMessageSerde bytesApiMessageSerde;
+ @SuppressWarnings("this-escape")
Review Comment:
I usually use https://kafka.apache.org/36/javadoc/allclasses-index.html as a
guide on what is public and what isn't. If this class in public, we are
probably missing it from here. From what I know, this class is used only by
TopicBased RLMM which is our internal implementation of RLMM plugin (hence not
public).
Let's wait to hear from Satish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
