ijuma commented on code in PR #14427:
URL: https://github.com/apache/kafka/pull/14427#discussion_r1335061735
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/TimeIndex.java:
##########
@@ -60,6 +60,7 @@ public TimeIndex(File file, long baseOffset, int
maxIndexSize) throws IOExceptio
this(file, baseOffset, maxIndexSize, true);
}
+ @SuppressWarnings("this-escape")
Review Comment:
I think the current implementation is conservative when it comes to any
assumptions for separate compilation units. After all, one can change the
implementation of the superclass method to invoke a method that is
overridden/implemented by the subclass without recompiling the subclass. I did
test various variations and it doesn't seem possible to fix the warning while
invoking any superclass methods from the constructor (directly or indirectly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
