divijvaidya commented on code in PR #14427:
URL: https://github.com/apache/kafka/pull/14427#discussion_r1334649199
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/TimeIndex.java:
##########
@@ -60,6 +60,7 @@ public TimeIndex(File file, long baseOffset, int
maxIndexSize) throws IOExceptio
this(file, baseOffset, maxIndexSize, true);
}
+ @SuppressWarnings("this-escape")
Review Comment:
Hmmm, just for my curiosity, the super class object is guaranteed to be
created in the sub-class ctor because `super()` is the first line in sub-class
ctor. Hence, there is no risk (of a partial object) if we call it's
non-overloadable methods because the super class instance whose methods we are
referring to will be completely constructed. Then why is this a warning?
(nevermind if you don't have the answer on top of your head. Java language
semantics is not my strong suite so I might be missing something here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
