imcdo commented on code in PR #14524:
URL: https://github.com/apache/kafka/pull/14524#discussion_r1355605756
##########
tests/kafkatest/tests/core/consume_bench_test.py:
##########
@@ -68,12 +67,21 @@ def produce_messages(self, topics, max_messages=10000):
self.logger.debug("Produce workload finished")
@cluster(num_nodes=10)
- @matrix(topics=[["consume_bench_topic[0-5]"]],
metadata_quorum=quorum.all_non_upgrade) # topic subscription
- @matrix(topics=[["consume_bench_topic[0-5]:[0-4]"]],
metadata_quorum=quorum.all_non_upgrade) # manual topic assignment
- def test_consume_bench(self, topics, metadata_quorum=quorum.zk):
+ @matrix(
+ topics=[
+ ["consume_bench_topic[0-5]"],
+ ["consume_bench_topic[0-5]:[0-4]"]
+ ],
+ metadata_quorum=quorum.all_non_upgrade,
+ use_new_coordinator=[True, False]
+ ) # topic subscription
Review Comment:
id argue we shouldn't tie configurations to eachother. if you wanted to do
that, then that would effect a lot of tests immediately. That would be the
easiest way to do that however now the configs are tied to eachother and you'd
have to idividually support each permutation of using the config (for instance
now you want to add colocated craft tests with new coordinator, or any other
flag in the future that will be kraft exclusive which i imagine might be many).
If you want to run with this globaly (all tests) Id argue the correct
approach is to just use the `session_context.globals` (the issue is that kraft
doesn't use this so kinda just stuck between a rock and a hard place, unless we
run with the skip descriptor that is already there on all tests as well).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
