dajac commented on code in PR #14524:
URL: https://github.com/apache/kafka/pull/14524#discussion_r1356464517
##########
tests/kafkatest/tests/core/consume_bench_test.py:
##########
@@ -68,12 +67,21 @@ def produce_messages(self, topics, max_messages=10000):
self.logger.debug("Produce workload finished")
@cluster(num_nodes=10)
- @matrix(topics=[["consume_bench_topic[0-5]"]],
metadata_quorum=quorum.all_non_upgrade) # topic subscription
- @matrix(topics=[["consume_bench_topic[0-5]:[0-4]"]],
metadata_quorum=quorum.all_non_upgrade) # manual topic assignment
- def test_consume_bench(self, topics, metadata_quorum=quorum.zk):
+ @matrix(
+ topics=[
+ ["consume_bench_topic[0-5]"],
+ ["consume_bench_topic[0-5]:[0-4]"]
+ ],
+ metadata_quorum=quorum.all_non_upgrade,
+ use_new_coordinator=[True, False]
+ ) # topic subscription
Review Comment:
Yeah, I agree that relying on the `quorum.all_non_upgrade` is not perfect.
The configuration that we are talking about here is temporary and will be
removed in AK 4.0 (~Q2 24). At this time, the old group coordinator will be
removed and KRaft will run by default with the new one. At the same time, we
will remove ZK as well. Therefore, this flag won't be needed at all in a couple
of months. We also want all the KRaft tests to run with the new group
coordinator until we reach this goal.
@imcdo Knowing this, does it change your point of view or do you still
believe that it is not good at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
