imcdo commented on code in PR #14524:
URL: https://github.com/apache/kafka/pull/14524#discussion_r1355750615
##########
tests/kafkatest/tests/core/consume_bench_test.py:
##########
@@ -44,7 +44,6 @@ def setUp(self):
self.trogdor.start()
if self.zk:
self.zk.start()
- self.kafka.start()
Review Comment:
this is kinda a limitation of ducktape, where the setup call doesn't
directly get any of the parameters of the test, meaning we can't know for sure
here directly what the args are via parameters. However how metadata team
around this was pulling the args directly from the test context (which we could
do here). I feel like its a bit less hacky to just move the start call as
setup isn't all that useful imo (you can write your own setup with the args you
want and call it at the start of test to achieve a similar result). but either
way will work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
