lianetm commented on code in PR #14390:
URL: https://github.com/apache/kafka/pull/14390#discussion_r1358313112
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -209,15 +218,21 @@ public NetworkClientDelegate.UnsentRequest
toUnsentRequest() {
requestTopicDataMap.put(topicPartition.topic(), topic);
}
- OffsetCommitRequest.Builder builder = new
OffsetCommitRequest.Builder(
- new OffsetCommitRequestData()
- .setGroupId(this.groupId)
-
.setGenerationIdOrMemberEpoch(generation.generationId)
- .setMemberId(generation.memberId)
- .setGroupInstanceId(groupInstanceId)
- .setTopics(new
ArrayList<>(requestTopicDataMap.values())));
+ OffsetCommitRequestData data = new OffsetCommitRequestData()
+ .setGroupId(groupId)
+ .setGenerationIdOrMemberEpoch(memberEpoch)
Review Comment:
Aligned with the idea that memberEpoch may not be present, I expect we
should only set this if we have one (like it is done for the memberID)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
