scyber commented on code in PR #14639:
URL: https://github.com/apache/kafka/pull/14639#discussion_r1372704905
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -215,16 +227,113 @@ public NetworkClientDelegate.UnsentRequest
toUnsentRequest() {
.setMemberId(generation.memberId)
.setGroupInstanceId(groupInstanceId)
.setTopics(new ArrayList<>(requestTopicDataMap.values())));
- return new NetworkClientDelegate.UnsentRequest(
+ // TODO: KAFKA-15592
+ NetworkClientDelegate.UnsentRequest resp = new
NetworkClientDelegate.UnsentRequest(
builder,
- coordinatorRequestManager.coordinator(),
+ coordinatorRequestManager.coordinator());
+ resp.future().whenComplete(
(response, throwable) -> {
- if (throwable == null) {
- future.complete(null);
- } else {
- future.completeExceptionally(throwable);
+ try {
+ if (throwable == null) {
+ onResponse(response);
+ } else {
+ onError(throwable,
resp.handler().completionTimeMs());
+ }
+ } catch (Throwable t) {
Review Comment:
I'm not sure if come to that point e.g. do we really need this try/catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
