philipnee commented on code in PR #14639:
URL: https://github.com/apache/kafka/pull/14639#discussion_r1374040965
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -382,9 +522,49 @@ private ClientResponse buildOffsetFetchClientResponse(
return buildOffsetFetchClientResponse(request, topicPartitionData,
error);
}
+ private ClientResponse buildOffsetCommitClientResponse(final
OffsetCommitResponse commitResponse,
+ final Errors error)
{
+ OffsetCommitResponseData data = new OffsetCommitResponseData();
+ OffsetCommitResponse response = new OffsetCommitResponse(data);
+ short apiVersion = 1;
+ return new ClientResponse(
+ new RequestHeader(ApiKeys.OFFSET_COMMIT, apiVersion, "", 1),
+ null,
+ "-1",
+ time.milliseconds(),
+ time.milliseconds(),
+ false,
+ null,
+ null,
+ commitResponse
+ );
+ }
+
+ public ClientResponse mockOffsetCommitResponse(String topic, int
partition, short apiKeyVersion, Errors error) {
Review Comment:
😅 Could you be specific: Do you mean by doing something like this?
```
response = mock(ClientResponse.class);
when(response.receivedTimeMs()).thenReturn(...);
when(response.data()).thenReturn(responseData);
return response;
```
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -382,9 +522,49 @@ private ClientResponse buildOffsetFetchClientResponse(
return buildOffsetFetchClientResponse(request, topicPartitionData,
error);
}
+ private ClientResponse buildOffsetCommitClientResponse(final
OffsetCommitResponse commitResponse,
+ final Errors error)
{
+ OffsetCommitResponseData data = new OffsetCommitResponseData();
+ OffsetCommitResponse response = new OffsetCommitResponse(data);
+ short apiVersion = 1;
+ return new ClientResponse(
+ new RequestHeader(ApiKeys.OFFSET_COMMIT, apiVersion, "", 1),
+ null,
+ "-1",
+ time.milliseconds(),
+ time.milliseconds(),
+ false,
+ null,
+ null,
+ commitResponse
+ );
+ }
+
+ public ClientResponse mockOffsetCommitResponse(String topic, int
partition, short apiKeyVersion, Errors error) {
Review Comment:
😅 Could you be specific: Do you mean by doing something like this?
```
response = mock(ClientResponse.class);
when(response.receivedTimeMs()).thenReturn(...);
when(response.data()).thenReturn(responseData);
return response;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
