philipnee commented on code in PR #14639:
URL: https://github.com/apache/kafka/pull/14639#discussion_r1374057359
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -127,7 +146,7 @@ public void maybeAutoCommit(final Map<TopicPartition,
OffsetAndMetadata> offsets
* Handles {@link
org.apache.kafka.clients.consumer.internals.events.CommitApplicationEvent}. It
creates an
* {@link OffsetCommitRequestState} and enqueue it to send later.
*/
- public CompletableFuture<Void> addOffsetCommitRequest(final
Map<TopicPartition, OffsetAndMetadata> offsets) {
+ public OffsetCommitRequestState addOffsetCommitRequest(final
Map<TopicPartition, OffsetAndMetadata> offsets) {
Review Comment:
Got it, I think the main reason was to test retryBackoff. I made some
changes according to your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
