junrao commented on code in PR #14705:
URL: https://github.com/apache/kafka/pull/14705#discussion_r1385389618
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##########
@@ -659,9 +660,21 @@ public TopicPartition key() {
*/
@Override
public void run() {
+ try {
+ runAsync().get();
Review Comment:
Hmm, while this guarantees ordering, it disables pipelining and thus
potentially reduces the throughput, since we have to wait for each event's
records to be fully replicated before processing the next event.
We probably could introduce a different callback in
`ReplicaManager.appendRecords` that's invoked when the records are appended to
the local log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
