junrao commented on code in PR #14705:
URL: https://github.com/apache/kafka/pull/14705#discussion_r1395031179
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##########
@@ -659,9 +660,21 @@ public TopicPartition key() {
*/
@Override
public void run() {
+ try {
+ runAsync().get();
Review Comment:
Another potential issue is the ordering. `withActiveContextOrThrow` holds a
partition level lock to make sure the record is replayed in the state machine
in the same order as it's appended to the log. With
`withActiveContextOrThrowAsync`, we hold the lock to replay the record, but
appends to the log without the lock. The could create a situation that the
state machine may not be exactly recreated by replaying records from the log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
