junrao commented on code in PR #14705:
URL: https://github.com/apache/kafka/pull/14705#discussion_r1387227928
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##########
@@ -659,9 +660,21 @@ public TopicPartition key() {
*/
@Override
public void run() {
+ try {
+ runAsync().get();
Review Comment:
Thanks for the explanation, Artem. Yes, it's true that the new group
coordinator only depends on acks=1.
Each new group coordinator thread handles requests from multiple groups and
multiple clients within the same group. In the proposed approach, if one
client's log append is blocked for additional async check, it blocks the
processing of other clients and other groups. So, it still seems to reduce the
overall throughput somewhat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
