philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400134639
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -353,7 +380,8 @@ private void testRetriable(final CommitRequestManager
commitRequestManger,
final
List<CompletableFuture<Map<TopicPartition, OffsetAndMetadata>>> futures) {
futures.forEach(f -> assertFalse(f.isDone()));
- time.sleep(500);
+ // The manager should backoff for 100ms
+ time.sleep(100);
Review Comment:
changed to 100 because we are now using jitter = 0, so the next backoff
should always be 100ms
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -373,7 +401,6 @@ private static Stream<Arguments>
offsetCommitExceptionSupplier() {
Arguments.of(Errors.INVALID_COMMIT_OFFSET_SIZE, false),
Arguments.of(Errors.UNKNOWN_TOPIC_OR_PARTITION, true),
Arguments.of(Errors.COORDINATOR_NOT_AVAILABLE, true),
- Arguments.of(Errors.NOT_COORDINATOR, true),
Review Comment:
Both are removed due to duplication, similar to the error below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
