philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400064245
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java:
##########
@@ -219,4 +219,14 @@ private void onResponse(
public Optional<Node> coordinator() {
return Optional.ofNullable(this.coordinator);
}
+
+ @Override
+ public NetworkClientDelegate.PollResult pollOnClose() {
Review Comment:
It was a hack to make sure poll can always send a find coordinator request.
Giving it a second thought, I think just calling poll is fine because if there
is an inflight request, we should poll the network client and wait. If we just
sent a failed one, we should backoff and then resend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
