philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400055966
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -90,14 +93,13 @@ public void run() {
while (running) {
try {
runOnce();
- } catch (final WakeupException e) {
- log.debug("WakeupException caught, consumer network thread
won't be interrupted");
+ } catch (final Throwable e) {
+ log.error("Unexpected error caught in consumer network
thread", e);
// swallow the wakeup exception to prevent killing the
thread.
Review Comment:
Thanks, a question here: Should we actually swallow the exception or
propagate the exception back to the application thread (wrap it with
KafkaException via BackgroundEventHandler)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
