cmccabe commented on PR #14860: URL: https://github.com/apache/kafka/pull/14860#issuecomment-1832698639
> Left a few comments, nothing major directly on the changes. > > I do have a high-level thought to put out there. This currently prevents the storage tool from formatting with a non production MetadataVersion and prevents the feature tool from updating a running cluster to a non-production MetadataVersion. I wonder if this will break anything, and I wonder if perhaps we should add a break-glass mechanism to circumvent these things in case something does break. While this may not require a KIP per-se, I would not be surprised if changing this causes issues for people somewhere. I don't think this will break any existing use-cases. I agree that having a break-glass mechanism would be useful for some testing cases. Although we need to be very sure to document that it shouldn't be used in production. Maybe we can follow up with a KIP later. But it would be too late for 3.7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
