cmccabe commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1409900140
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -59,10 +59,14 @@ object StorageTool extends Logging {
case "format" =>
val directories = configToLogDirectories(config.get)
val clusterId = namespace.getString("cluster_id")
- val metadataVersion = getMetadataVersion(namespace,
Option(config.get.interBrokerProtocolVersionString))
+ val metadataVersion = getMetadataVersion(namespace,
+
Option(config.get.originals.get(KafkaConfig.InterBrokerProtocolVersionProp)).map(_.toString))
if (!metadataVersion.isKRaftSupported) {
throw new TerseFailure(s"Must specify a valid KRaft metadata
version of at least 3.0.")
}
+ if (!metadataVersion.isProduction()) {
+ throw new TerseFailure(s"Metadata version ${metadataVersion} is
not ready for production use yet.")
+ }
Review Comment:
I created an internal configuration `unstable.metadata.versions.enable` to
bypass this. Since it is internal and undocumented, it doesn't need a KIP.
(Also see the very similar `unstable.api.versions.enable`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
