apoorvmittal10 commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1413198971
##########
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##########
@@ -45,10 +45,6 @@ public short oldestAllowedVersion() {
@Override
public BrokerRegistrationRequest build(short version) {
- if (version < 2) {
- // Reset the PreviousBrokerEpoch to default if not supported.
- data.setPreviousBrokerEpoch(new
BrokerRegistrationRequestData().previousBrokerEpoch());
- }
Review Comment:
@cmccabe I am not an expert with the change in the PR but this change might
have broken the tests for `BrokerRegistrationRequestTest`, tests fails for
`version < 2`
Also I might be missing something to read the builds for this PR but as far
as I can check I don't see any successful build for the PR as well, please let
me know if I am reading something wrong.
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/activity?branch=PR-14860
cc: @junrao @pprovenzano @dajac @AndrewJSchofield (for failing tests in the
other PR builds for `BrokerRegistrationRequestTest`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
