lianetm commented on code in PR #14557:
URL: https://github.com/apache/kafka/pull/14557#discussion_r1425965837
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -457,120 +535,224 @@ public void onResponse(final ClientResponse response) {
}
}
- private void handleRetriableError(Errors error, ClientResponse
response) {
- if (error == COORDINATOR_NOT_AVAILABLE ||
- error == NOT_COORDINATOR ||
- error == REQUEST_TIMED_OUT) {
-
coordinatorRequestManager.markCoordinatorUnknown(error.message(),
response.receivedTimeMs());
+ /**
+ * Enqueue the request to be retried with exponential backoff. This
will fail the request
+ * without retrying if the request timer expired.
+ */
+ @Override
+ void retry(long currentTimeMs, Throwable throwable) {
+ if (!requestTimer.isPresent() || requestTimer.get().isExpired()) {
Review Comment:
Agree, but not using timers anymore (moved to expirationTimeMs) so not
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
