lianetm commented on code in PR #14557:
URL: https://github.com/apache/kafka/pull/14557#discussion_r1425995440
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -741,61 +767,86 @@ boolean reconcile() {
revokedPartitions
);
- CompletableFuture<Void> revocationResult;
- if (!revokedPartitions.isEmpty()) {
- revocationResult = revokePartitions(revokedPartitions);
+ // Commit offsets if auto-commit enabled before reconciling a new
assignment. Request will
+ // be retried until it succeeds, fails with non-retriable error, or
timer expires.
+ CompletableFuture<Void> commitResult;
+
+ if (commitRequestManager.autoCommitEnabled()) {
+ // TODO: review auto commit time boundary. This will be
effectively bounded by the
Review Comment:
I already updated this with an initial approach aligned with the rebalance
timeout as the TODO suggested and removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
