federico-weisse-sportsbet commented on code in PR #15413:
URL: https://github.com/apache/kafka/pull/15413#discussion_r1500038952
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractConfig {
+ "Enabling idempotence requires this config value to be greater
than 0."
+ " If conflicting configurations are set and idempotence is not
explicitly enabled, idempotence is disabled."
+ "<p>"
- + "Allowing retries while setting <code>enable.idempotence</code>
to <code>false</code> and <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION +
"</code> to 1 will potentially change the"
+ + "Allowing retries while setting <code>enable.idempotence</code>
to <code>false</code> and <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION +
"</code> to greater than 1 will potentially change the"
Review Comment:
Good to know, thanks for the info, could you provide more info on when a
re-ordering (not so interested on duplicates for my use case) can happen, if
there is a really unlikely edge case we may live with it.
On the other hand, do you have an idea of how slow is using using
idempotency vs in flight requests =1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
