federico-weisse-sportsbet commented on code in PR #15413:
URL: https://github.com/apache/kafka/pull/15413#discussion_r1500201095
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractConfig {
+ "Enabling idempotence requires this config value to be greater
than 0."
+ " If conflicting configurations are set and idempotence is not
explicitly enabled, idempotence is disabled."
+ "<p>"
- + "Allowing retries while setting <code>enable.idempotence</code>
to <code>false</code> and <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION +
"</code> to 1 will potentially change the"
+ + "Allowing retries while setting <code>enable.idempotence</code>
to <code>false</code> and <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION +
"</code> to greater than 1 will potentially change the"
Review Comment:
In any case reconsidering the case of the connection closed on client side,
if inflight = 1, it should send one batch at a time, so, I wonder if that case
is no more about duplicated messages than re-ordering.
I guess the only way to have an un-orderer is if the broker gets first new
connection batches, like
new_conn_batch1, new_conn_batch2, old_conn_batch1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
