jolshan commented on code in PR #15413:
URL: https://github.com/apache/kafka/pull/15413#discussion_r1500063914
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractConfig {
+ "Enabling idempotence requires this config value to be greater
than 0."
+ " If conflicting configurations are set and idempotence is not
explicitly enabled, idempotence is disabled."
+ "<p>"
- + "Allowing retries while setting <code>enable.idempotence</code>
to <code>false</code> and <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION +
"</code> to 1 will potentially change the"
+ + "Allowing retries while setting <code>enable.idempotence</code>
to <code>false</code> and <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION +
"</code> to greater than 1 will potentially change the"
Review Comment:
In the case where a connection is closed on the client side, it can still
arrive later on the server. Even though the client disconnects and resumes with
a new connection, a message from the old connection can come in out of order.
This can happen when there is a temporary network issue.
I don't have metrics on latency comparisons with idempotency vs infligh
requests = 1, but I wouldnt suspect it should be too much. Idempotency involves
a sequence check broker side which shouldn't take too much time per produce
request. It would be an interesting test to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
