brandboat commented on code in PR #15715:
URL: https://github.com/apache/kafka/pull/15715#discussion_r1564660683
##########
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##########
@@ -190,10 +192,10 @@ private void processClusterTest(ExtensionContext context,
ClusterTest annot, Clu
ClusterConfig config = builder.build();
Review Comment:
There are places like
https://github.com/apache/kafka/blob/0b4e9afee2ace7edf6ff8690e070100b98627836/core/src/test/scala/integration/kafka/server/KafkaServerKRaftRegistrationTest.scala#L74
need to add extra properties and then restart cluster. If we make
ClusterConfig immutable, this may requires more effort to think about how do we
handle this scenario. What I want to say is the work could be huge, and
overwhelm what we want to address in this JIRA. i.e. define per
broker/controller property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
