chia7712 commented on code in PR #15715:
URL: https://github.com/apache/kafka/pull/15715#discussion_r1564660916
##########
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##########
@@ -190,10 +192,10 @@ private void processClusterTest(ExtensionContext context,
ClusterTest annot, Clu
ClusterConfig config = builder.build();
Review Comment:
> Sure, but that could require some efforts here, there are plenty of places
directly invoke ClusterConfig#serverProperties and add server properties before
cluster start. e.g. KafkaServerKRaftRegistrationTest.
yep, but it is worth the effort. We adopt the builder pattern already, so
the built object should be immutable. If the refactor could includes huge
changes, we can have a separate PR for that. Or we can refactor them one by one.
1. `ClusterConfig`
2. `BrokerNode`
3. `ControllerNode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
