kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1583520696
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -998,7 +958,7 @@ public List<PartitionInfo> partitionsFor(String topic,
Duration timeout) {
wakeupTrigger.setActiveTask(topicMetadataEvent.future());
try {
Map<String, List<PartitionInfo>> topicMetadata =
- applicationEventHandler.addAndGet(topicMetadataEvent,
timer);
+ applicationEventHandler.addAndGet(topicMetadataEvent);
Review Comment:
Removed use of `Timer` in favor of calculating the deadline from the `time`
and `timeout` directly.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1107,7 +1067,7 @@ public Map<TopicPartition, OffsetAndTimestamp>
offsetsForTimes(Map<TopicPartitio
return listOffsetsEvent.emptyResults();
}
- return applicationEventHandler.addAndGet(listOffsetsEvent, timer)
+ return applicationEventHandler.addAndGet(listOffsetsEvent)
Review Comment:
Removed use of `Timer` in favor of calculating the deadline from the `time`
and `timeout` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
