lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585035057
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1853,6 +1824,40 @@ private void subscribeInternal(Collection<String>
topics, Optional<ConsumerRebal
}
}
+ /**
+ * Process the events—if any—that were produced by the {@link
ConsumerNetworkThread network thread}.
+ * It is possible that {@link ErrorEvent an error}
+ * could occur when processing the events. In such cases, the processor
will take a reference to the first
+ * error, continue to process the remaining events, and then throw the
first error that occurred.
+ */
+ private boolean process(EventProcessor<BackgroundEvent> processor) {
Review Comment:
what about renaming this to be explicit about what we process here? It gets
confusing given that at this consumer level we're dealing with app events and
background events.
`processBackgroundEvents` feels pretty clear, and I know there is already
another one called liked that, but the other one is more about
`awaitFutureProcessingBackgroundEvents` , because it actually blocks for a
time, only used from the unsubscribe, so maybe rename here and there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
