lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585083395


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1892,13 +1897,13 @@ private void subscribeInternal(Collection<String> 
topics, Optional<ConsumerRebal
      * @return {@code true} if the event completed within the timeout, {@code 
false} otherwise
      */
     // Visible for testing
-    <T> T processBackgroundEvents(EventProcessor<?> eventProcessor,
+    <T> T processBackgroundEvents(EventProcessor<BackgroundEvent> 
eventProcessor,

Review Comment:
   Regarding the func doc, typo and clarification:
   
   > When the application thread sees ..., it is processed, and **then a ...is 
then** enqueued by the application thread **on the background event queue**
   
   The app thread enqueues the event in an **application event queue** (that 
the background thread consumes), right? In the doc we ended up mentioning the 
background and app thread both adding to the background event queue. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to