ableegoldman commented on code in PR #15909:
URL: https://github.com/apache/kafka/pull/15909#discussion_r1595957783
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -193,11 +193,12 @@ public NetworkClientDelegate.PollResult poll(long
currentTimeMs) {
}
pollTimer.update(currentTimeMs);
if (pollTimer.isExpired() && !membershipManager.isLeavingGroup()) {
- logger.warn("Consumer poll timeout has expired. This means the
time between " +
+ logger.warn("Consumer poll timeout has expired, exceeded by {} ms.
This means the time between " +
Review Comment:
IIUC this is what gets logged when the _heartbeat thread_ notices the
consumer has failed to poll in time and dropped out of the group -- so the
"time exceeded" is just going to be roughly the max poll interval + the
heartbeat interval, no?
I do think it's a great idea to log the amount of time by which the max poll
interval was exceeded, but imo the more useful information is how long after
the max poll interval the consumer took to actually hit poll again, not how
long the heartbeat thread took to notice it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
