AndrewJSchofield commented on code in PR #15909:
URL: https://github.com/apache/kafka/pull/15909#discussion_r1596418576
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -193,11 +193,12 @@ public NetworkClientDelegate.PollResult poll(long
currentTimeMs) {
}
pollTimer.update(currentTimeMs);
if (pollTimer.isExpired() && !membershipManager.isLeavingGroup()) {
- logger.warn("Consumer poll timeout has expired. This means the
time between " +
+ logger.warn("Consumer poll timeout has expired, exceeded by {} ms.
This means the time between " +
Review Comment:
I see what you mean. I think that the background thread will notice more
quickly than you said, but this just means the "time exceeded" is going to be
very close to max poll interval. The heartbeat request manager checks to see
whether it is time to send a heartbeat more regularly than it actually sends a
heartbeat.
Maybe enhancing the logging in `HeartbeatRequestManager.resetPollTimer`
would be a suitable point. This is where the heartbeat request manager will
notice that it has already left the group because of delinquent polling, and
rejoins when the next poll occurs. @lianetm that's probably workable I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
